try_to_load_from_cache returns cached non-existence#1039
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Codecov Report
@@ Coverage Diff @@
## main #1039 +/- ##
==========================================
+ Coverage 83.01% 83.03% +0.01%
==========================================
Files 36 36
Lines 3822 3825 +3
==========================================
+ Hits 3173 3176 +3
Misses 649 649
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
(Note: related to huggingface/transformers#18871) |
Wauplin
approved these changes
Sep 8, 2022
Contributor
Wauplin
left a comment
Wauplin
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for taking care of the docstring and the tests.
Contributor
|
Will fix #1033. |
LysandreJik
approved these changes
Sep 9, 2022
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Nice, thank you for completing the docs!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns
try_to_load_from_cachewith its Transformers counterpart to return a special value when a file does not exist for a given repo/revision and that fact has been cached.